fix: ensure lib is built before examples:build#185
Merged
Conversation
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-wiki-explorer
commit: |
ochafik
force-pushed
the
ochafik/fix-examples-build-order
branch
3 times, most recently
from
9d8126c to
8bab9ef
Compare
ochafik
force-pushed
the
ochafik/fix-examples-build-order
branch
from
aae2a86 to
fff7a92
Compare
Add preexamples:build hook to automatically run `npm run build` before `examples:build`. This ensures examples always type-check against the latest library code, catching breaking changes during development. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add scripts/check-versions.mjs to verify that example package.json files
reference the correct version of @modelcontextprotocol/ext-apps.
- Allows "../.." (local dev) or "^{root-version}" as valid dependencies
- Runs in CI before npm install to catch mismatches early
- Available locally via `npm run check:versions`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
ochafik
force-pushed
the
ochafik/fix-examples-build-order
branch
from
fff7a92 to
21ff936
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preexamples:buildhook to automatically runnpm run buildbeforeexamples:buildbuild:allto just callexamples:build(the pre-hook handles building the lib)Changes
preexamples:buildhook - ensures lib is built before examplesscripts/check-versions.mjs):^{root-version}or../..npm installnpm run check:versionsTest plan
npm run examples:buildnow runsnpm run buildfirst (via pre-hook)npm run build:allstill works as expectednpm run check:versionspasses with correct versions🤖 Generated with Claude Code